Fix templated __constant__ variable handling #1069
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
pvelesko
force-pushed
the
fix-977
branch
2 times, most recently
from
472bc6e to
5551551
Compare
pvelesko
added
in-progress
pvelesko
force-pushed
the
fix-977
branch
2 times, most recently
from
a156215 to
2ab1999
Compare
- Introduced TestTemplatedConstantMemcpy.hip to reproduce Issue #977. - The test verifies the behavior of hipMemcpyToSymbol with templated constant memory. - Updated CMakeLists.txt to include the new test in the build process.
- SPVRegister: tolerate duplicate variable registration for identical (Ptr, Name) pairs - CHIPBackend: restore invariant in Device::getOrCreateModule, remove early null return - CHIPBindings: remove unreliable runtime fallback with address-range heuristics - HipGlobalVariables: maintain original COMDAT exclusion logic (reverted from initial approach) - TestTemplatedConstantMemcpy: add device-side validation kernel to verify actual data visibility Fixes: #977
Replace malloc + placement new with std::unique_ptr for synthetic SPVVariable objects created for device-only variables (e.g., templated __constant__ variables). The static vector now stores unique_ptr which ensures proper destruction of std::string members and memory deallocation when the program exits.
- Replace malloc + placement new with unique_ptr for synthetic SPVVariable objects created for device-only variables (templated __constant__ vars) - Add mutex protection around static SyntheticVars vector access - Add duplicate check to prevent concurrent threads from creating same var - Remove unreachable dead code in SPVRegister::bindVariable that checked for special abort/heap variables after already returning for same-name case
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes: #977